From 8481a0e86fe5ec397b8afe9ce5a35c293d3d7a8a Mon Sep 17 00:00:00 2001
From: realrafi <mahdi47rafie@gmail.com>
Date: Wed, 8 Jul 2026 10:50:40 +0330
Subject: [PATCH] refactor: removed unnecessary functions from remark

---
 .../controllers/remark.controller.ts          | 22 ++-----------------
 .../task-manager/providers/remark.service.ts  | 13 -----------
 2 files changed, 2 insertions(+), 33 deletions(-)

diff --git a/src/modules/task-manager/controllers/remark.controller.ts b/src/modules/task-manager/controllers/remark.controller.ts
index d5933b9..9818f58 100644
--- a/src/modules/task-manager/controllers/remark.controller.ts
+++ b/src/modules/task-manager/controllers/remark.controller.ts
@@ -1,5 +1,5 @@
-import { Controller, Get, Post, Patch, Delete, Param, Body, Query } from "@nestjs/common";
-import { ApiTags, ApiOperation, ApiResponse, ApiParam, ApiQuery } from "@nestjs/swagger";
+import { Controller, Post, Patch, Delete, Param, Body } from "@nestjs/common";
+import { ApiTags, ApiOperation, ApiResponse, ApiParam } from "@nestjs/swagger";
 import { RemarkService } from "../providers/remark.service";
 import { CreateRemarkDto } from "../dto/remark/create-remark.dto";
 import { UpdateRemarkDto } from "../dto/remark/update-remark.dto";
@@ -17,24 +17,6 @@ import { PermissionEnum } from "../../users/enums/permission.enum";
 export class RemarkController {
   constructor(private readonly remarkService: RemarkService) {}
 
-  @Get()
-  @ApiOperation({ summary: "Get all remarks, optionally filtered by task" })
-  @ApiQuery({ name: "taskId", required: false, description: "Filter remarks by task ID" })
-  @ApiResponse({ status: 200, description: "List of remarks", type: [TMRemark] })
-  findAll(@Query("taskId") taskId?: string): Promise<TMRemark[]> {
-    if (taskId) return this.remarkService.findByTask(taskId);
-    return this.remarkService.findAll();
-  }
-
-  @Get(":id")
-  @ApiOperation({ summary: "Get a remark by ID" })
-  @ApiParam({ name: "id", description: "Remark ID" })
-  @ApiResponse({ status: 200, description: "Remark found", type: TMRemark })
-  @ApiResponse({ status: 404, description: "Remark not found" })
-  findOne(@Param("id") id: string): Promise<TMRemark> {
-    return this.remarkService.findOneOrFail(id);
-  }
-
   @Post()
   @ApiOperation({ summary: "Create a new remark" })
   @ApiResponse({ status: 201, description: "Remark created", type: TMRemark })
diff --git a/src/modules/task-manager/providers/remark.service.ts b/src/modules/task-manager/providers/remark.service.ts
index f48ed1f..50fe024 100644
--- a/src/modules/task-manager/providers/remark.service.ts
+++ b/src/modules/task-manager/providers/remark.service.ts
@@ -13,19 +13,6 @@ export class RemarkService {
     private readonly taskService: TaskService,
   ) {}
 
-  findAll(): Promise<TMRemark[]> {
-    return this.remarkRepository.find({ relations: { task: true } });
-  }
-
-  findByTask(taskId: string): Promise<TMRemark[]> {
-    return this.remarkRepository.find({
-      where: { taskId },
-      relations: {
-        task: true,
-      },
-    });
-  }
-
   async findOneOrFail(id: string): Promise<TMRemark> {
     const remark = await this.remarkRepository.findOne({ where: { id } });
     if (!remark) throw new NotFoundException(remarkMessage.REMARK_NOT_FOUND);