refactor: removed unnecessary functions from task

This commit is contained in:
2026-07-08 10:48:03 +03:30
parent b0668c7b2c
commit b32d613a1b
4 changed files with 27 additions and 53 deletions
@@ -1,5 +1,5 @@
import { Controller, Get, Post, Patch, Delete, Param, Body, Query } from '@nestjs/common';
import { ApiTags, ApiOperation, ApiResponse, ApiParam, ApiQuery } from '@nestjs/swagger';
import { Controller, Get, Post, Patch, Delete, Param, Body } from '@nestjs/common';
import { ApiTags, ApiOperation, ApiResponse, ApiParam } from '@nestjs/swagger';
import { TaskService } from '../providers/task.service';
import { CreateTaskDto } from '../dto/task/create-task.dto';
import { UpdateTaskDto } from '../dto/task/update-task.dto';
@@ -11,6 +11,7 @@ import { UserDec } from '../../../common/decorators/user.decorator';
import { ParamDto } from '../../../common/DTO/param.dto';
import { PermissionsDec } from '../../../common/decorators/permission.decorator';
import { PermissionEnum } from '../../users/enums/permission.enum';
import { ITokenPayload } from '../../auth/interfaces/IToken-payload';
@AuthGuards()
@AdminRoute()
@@ -19,26 +20,6 @@ import { PermissionEnum } from '../../users/enums/permission.enum';
export class TaskController {
constructor(private readonly taskService: TaskService) {}
@Get()
@PermissionsDec(PermissionEnum.TASK)
@ApiOperation({ summary: 'Get all tasks, optionally filtered by phase' })
@ApiQuery({ name: 'taskPhaseId', required: false, description: 'Filter tasks by task phase ID' })
@ApiResponse({ status: 200, description: 'List of tasks', type: [TMTask] })
findAll(@Query('taskPhaseId') taskPhaseId?: string): Promise<TMTask[]> {
if (taskPhaseId) return this.taskService.findByPhase(taskPhaseId);
return this.taskService.findAll();
}
@Get(':id')
@PermissionsDec(PermissionEnum.TASK)
@ApiOperation({ summary: 'Get a task by ID' })
@ApiParam({ name: 'id', description: 'Task ID' })
@ApiResponse({ status: 200, description: 'Task found', type: TMTask })
@ApiResponse({ status: 404, description: 'Task not found' })
findOne(@Param('id') id: string): Promise<TMTask> {
return this.taskService.findOneOrFail(id);
}
@Post()
@PermissionsDec(PermissionEnum.TASK)
@ApiOperation({ summary: 'Create a new task' })
@@ -85,9 +66,9 @@ export class TaskController {
@ApiResponse({ status: 200, description: 'Task detail received!' })
@ApiResponse({ status: 404, description: 'Task not found' })
getTaskDetail(
@UserDec('id') userId: string,
@UserDec() user: ITokenPayload,
@Param() paramDto: ParamDto
): Promise<TMTask | null> {
return this.taskService.getTaskDetail(userId, paramDto.id);
return this.taskService.getTaskDetail(user.id, user.permissions, paramDto.id);
}
}