Refactor RoleService to implement soft delete functionality for roles by updating the deletedAt timestamp instead of hard deletion; streamline role filtering logic for improved readability.

This commit is contained in:
2025-11-18 11:04:44 +03:30
parent 2da66cdd86
commit 81fa0ca2b9
+2 -6
View File
@@ -73,9 +73,7 @@ export class RoleService {
let filtered = roles;
if (name) {
filtered = roles.filter(
r =>
r.name.toLowerCase().includes(name.toLowerCase()) ||
r.title.toLowerCase().includes(name.toLowerCase()),
r => r.name.toLowerCase().includes(name.toLowerCase()) || r.title.toLowerCase().includes(name.toLowerCase()),
);
}
@@ -130,9 +128,7 @@ export class RoleService {
throw new NotFoundException('Role not found');
}
// Soft delete by removing from database or mark as deleted
// For now, we'll do a hard delete since Role entity doesn't have deletedAt
await this.em.removeAndFlush(role);
await this.roleRepository.update({ id }, { deletedAt: new Date() });
return { message: 'Role deleted successfully' };
}
}