Refactor RoleService to implement soft delete functionality for roles by updating the deletedAt timestamp instead of hard deletion; streamline role filtering logic for improved readability.
This commit is contained in:
@@ -73,9 +73,7 @@ export class RoleService {
|
||||
let filtered = roles;
|
||||
if (name) {
|
||||
filtered = roles.filter(
|
||||
r =>
|
||||
r.name.toLowerCase().includes(name.toLowerCase()) ||
|
||||
r.title.toLowerCase().includes(name.toLowerCase()),
|
||||
r => r.name.toLowerCase().includes(name.toLowerCase()) || r.title.toLowerCase().includes(name.toLowerCase()),
|
||||
);
|
||||
}
|
||||
|
||||
@@ -130,9 +128,7 @@ export class RoleService {
|
||||
throw new NotFoundException('Role not found');
|
||||
}
|
||||
|
||||
// Soft delete by removing from database or mark as deleted
|
||||
// For now, we'll do a hard delete since Role entity doesn't have deletedAt
|
||||
await this.em.removeAndFlush(role);
|
||||
await this.roleRepository.update({ id }, { deletedAt: new Date() });
|
||||
return { message: 'Role deleted successfully' };
|
||||
}
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user